The Wayback Machine - https://web.archive.org/web/20211011215036/https://github.com/laravel/framework/pull/39034
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] PHP 8.1 Support #39034

Draft
wants to merge 20 commits into
base: 8.x
Choose a base branch
from
Draft

[8.x] PHP 8.1 Support #39034

wants to merge 20 commits into from

Conversation

@driesvints
Copy link
Member

@driesvints driesvints commented Sep 29, 2021

This PR contains more PHP 8.1 fixes:

  • Remove mimicking PHP 8.0 now that we're nearing the PHP 8.1 release date
  • Add prefer-lowest builds
  • Add separate build step for minimum versions for Symfony, PHPUnit & CommonMark we cannot bump these through Composer
  • Bumps some libraries for PHP 8.1 compatibility
  • Added more clearer message for skipped mail tests on PHP 8.1 since SwiftMailer won't be patched for it
  • Unskipped PHP 8.1 tests
.github/workflows/tests.yml Outdated Show resolved Hide resolved
@driesvints driesvints force-pushed the php8.1-fixes branch 2 times, most recently from 997118a to 219cc60 Sep 30, 2021
@tillkruss
Copy link
Contributor

@tillkruss tillkruss commented Sep 30, 2021

Predis fix merged here: predis/predis@92adf32

composer.json Outdated Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
@driesvints
Copy link
Member Author

@driesvints driesvints commented Oct 4, 2021

@GrahamCampbell have patience 😅

@GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Oct 4, 2021

@driesvints I don't follow? ^1.1.9 is better, coz it works right now and will also work when the tag is actually created (because the branch is named 1.1 on GitHub, so composer understands that the code there will become 1.1.9 in the future)

@driesvints
Copy link
Member Author

@driesvints driesvints commented Oct 4, 2021

I will change it once Till has tagged a new release.

@GrahamCampbell
Copy link
Member

@GrahamCampbell GrahamCampbell commented Oct 4, 2021

I just don't get why change it to v1.1.x-dev when you could have just cranked the patch number by 1?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants