The Wayback Machine - https://web.archive.org/web/20220205230229/https://github.com/laravel/framework/pull/39404
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Improves internal ./bin/test script #39404

Merged
merged 4 commits into from Oct 28, 2021
Merged

Conversation

@nunomaduro
Copy link
Member

@nunomaduro nunomaduro commented Oct 28, 2021

This pull request improves the script ./bin/test.sh on the following topics:

  • Fixes 3 failing tests.
  • Lower the skipped tests from 17 to 12. As an example, Dynamo DB tests are now been run.
  • You can now specify the PHP version by doing: ./bin/test.sh --php 8.0.
  • PHP 8 is now the default version.
  • Docker services are no longer "shut down" after the script run, so re-run the tests become faster.
  • Docker services may be shut down by using ./bin/test.sh --down.
  • Fixes the usage of the MySQL service on M1.

@GrahamCampbell I may need your help with the remaining 10 skipped tests that concern the "redis" extension. It's out of my "docker" league. But we can do it on a different pull request.

You may "pass" PHPUnit options like so: ./bin/test.sh - ./your-test-name

@nunomaduro nunomaduro requested a review from taylorotwell Oct 28, 2021
@taylorotwell taylorotwell merged commit f7c9f2c into 8.x Oct 28, 2021
34 checks passed
@taylorotwell taylorotwell deleted the chore/improves-run-tests branch Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants