The Wayback Machine - https://web.archive.org/web/20201013034632/https://github.com/cube-js/cube.js/pull/1154
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Misc(playgroud): Use jsx ext for React components #1154

Open
wants to merge 1 commit into
base: master
from

Conversation

@ovr
Copy link
Member

@ovr ovr commented Sep 28, 2020

Hey!

It's a small change related naming React component, it doesnot affect git history, only renaming!

Motivation

1. Help IDE/Editors recognize JavaScript React style (improve DX). JSX is superset on top of JS, but it's not a JS.

  1. Without jsx

Webstorm

image

Vscode

image

  1. With JSX

Webstorm

image

VSCode

image

2. Specify rules on jsx ext

{
'react/jsx-filename-extension': [2, { extensions: ['.jsx'] }],
}
@ovr ovr changed the title Misc(playgroud): Use jsx ext for React components [WIP] Misc(playgroud): Use jsx ext for React components Sep 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.