The Wayback Machine - https://web.archive.org/web/20220402012237/https://github.com/IronLanguages/ironpython3/pull/576
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct NuGet API URL #576

Merged
merged 1 commit into from Mar 16, 2019
Merged

Correct NuGet API URL #576

merged 1 commit into from Mar 16, 2019

Conversation

BCSharp
Copy link
Collaborator

@BCSharp BCSharp commented Mar 16, 2019

I have finally got the build working on my macOS, but it required a change in the NuGet API URL. The old URL points to a non-existent resource and I don't know how the build could have been working on Linux, CI, or on macOS for other people. Perhaps some clever rewriting rules that I don't have. Anyway, the correct URL for the packages index can be easily verified in a web browser.

@slozier
Copy link
Contributor

@slozier slozier commented Mar 16, 2019

LGTM though I'm not sure we even need the packageSources. I'm pretty sure msbuild will pull from the proper source anyway.

@slozier slozier merged commit 59c047d into IronLanguages:master Mar 16, 2019
1 of 2 checks passed
@slozier
Copy link
Contributor

@slozier slozier commented Mar 16, 2019

@BCSharp I'm glad you have a mac to test this stuff, I don't have one so it's hard to debug things.

@BCSharp BCSharp deleted the nuget_api branch Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants