The Wayback Machine - https://web.archive.org/web/20211111192056/https://github.com/chartjs/Chart.js/pull/9570
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing typings of helpers, add automatic test #9570

Merged
merged 2 commits into from Sep 2, 2021
Merged

Add missing typings of helpers, add automatic test #9570

merged 2 commits into from Sep 2, 2021

Conversation

Reviewers

@etimberg etimberg

Assignees
No one assigned
Labels
type: types
Projects
None yet
Milestone
Version 3.6.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@kurkle @etimberg
@kurkle
Copy link
Collaborator

@kurkle kurkle commented Aug 22, 2021

Several helpers were missing from the type definitions.
Created an automatic generator to verify all (public) helper functions have type definitions and added the missing definitions.
@kurkle
Add missing typings of helpers, add automatic test
a9095b1
@kurkle
Add error handling to autogen.js
6deaaa6
@etimberg etimberg added this to the Version 3.6.0 milestone Sep 2, 2021
@etimberg etimberg merged commit 3ed9455 into chartjs:master Sep 2, 2021
10 checks passed
Loading
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment