The Wayback Machine - https://web.archive.org/web/20211111192213/https://github.com/chartjs/Chart.js/pull/9768
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't require --grep to be given on the command line #9768

Merged
merged 1 commit into from Oct 14, 2021

Conversation

Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@joshkel
Copy link
Contributor

@joshkel joshkel commented Oct 14, 2021

This makes it easier to use the karma CLI directly, if desired, and makes it easier to use WebStorm's integrated debugger (which makes up karma command-line invocations itself). Prior to this change, if --grep isn't given, Karma looks for *undefined*.js and finds no tests to run.

This makes it easier to use the `karma` CLI directly, if desired, and makes it easier to use WebStorm's integrated debugger (which makes up `karma` command-line invocations itself).  Prior to this change, if `--grep` isn't given, Karma looks for `*undefined*.js` and finds no tests to run.
kurkle
kurkle approved these changes Oct 14, 2021
@etimberg etimberg merged commit dd78ba0 into chartjs:master Oct 14, 2021
5 checks passed
Loading
@joshkel joshkel deleted the karma-grep branch Oct 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment