The Wayback Machine - https://web.archive.org/web/20220322174614/https://github.com/chartjs/Chart.js/pull/9720
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed 4 links #9720

Merged
merged 14 commits into from Oct 15, 2021
Merged

Fixed 4 links #9720

merged 14 commits into from Oct 15, 2021

Conversation

mikidoodle
Copy link
Contributor

@mikidoodle mikidoodle commented Oct 5, 2021

I’ve fixed 3 links in docs/general/performance.md and one link in docs/general/padding.md.
This is so that your docs are more responsive and work better.

Its not for a T-shirt and a few stickers.
not at all…

ok it is for a t-shirt and a few stickers.
Have a nice day!

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Oct 5, 2021

Does not look like the links need fixing?
https://www.chartjs.org/docs/master/

@mikidoodle
Copy link
Contributor Author

@mikidoodle mikidoodle commented Oct 5, 2021

True. But when I try it in the GitHub Preview, it returns a 404 error.

@etimberg etimberg added this to the Version 3.6.0 milestone Oct 5, 2021
@kurkle
Copy link
Collaborator

@kurkle kurkle commented Oct 5, 2021

True. But when I try it in the GitHub Preview, it returns a 404 error.

What is Github Preview?
I'd guess it is not building the docs and not serving them with vuepress. So things will be broken.

@mikidoodle
Copy link
Contributor Author

@mikidoodle mikidoodle commented Oct 5, 2021

Its something I call it, I dont know if that’s what it’s actually called.
Here:
IMG_7519

@kurkle
Copy link
Collaborator

@kurkle kurkle commented Oct 5, 2021

Ok, it would be optimal if the links work in the preview too.

@etimberg etimberg removed this from the Version 3.6.0 milestone Oct 9, 2021
kurkle
kurkle approved these changes Oct 15, 2021
@kurkle kurkle merged commit 6c22074 into chartjs:master Oct 15, 2021
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants