Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add integration tests #98
Comments
This is a breaking change, but it appears that this method has been broken for some time now and no one has complained yet, so I'm going to assume no one is using it yet. Notably, this is also the first (of many, I'm sure) bug I've discovered while working on the new integration tests (#98). Yay for better tests!
|
I am new to go as well as go-github project. I am trying to set up the go repository and was able to run the basicauth example. How are the tests set up? I am unable to test the individual test files here. I am running these tests locally. |
What repository exactly?
The go-github project uses standard Go tests. They're inside the
Please see here for the best places to ask Go questions: |
|
I am sorry for spelling out the repository wrong. I am using the go-github repository. After cloning the repository, i tried running the integration test cases in the tests/integration folder with GITHUB_AUTH_TOKEN set in environment. Here is what I did from the GitHub folder Here is the error I got ../tests/integration/repos_test.go:117: branch.Protection undefined (type *github.Branch has no field or method Protection) Is the integration folder broken, can i raise an issue and try to solve? All the tests in the GitHub folder of the go-github project passes. it is only the integration files that seem to be broken. |
No problem, I just wanted to make sure I'm not misunderstanding you.
Yes, it is, I got the same errors. Please do. Open a new issue, and feel free to work on a PR to resolve it. The integration tests are run manually, so they got out of date after some breaking API changes in the library. Thanks! By the way, don't forget to read over the integration tests README. You should run them with (Also, feel free to review PR #506 since it's related.) |
This is an ongoing work item to add integration tests for the entire library. Unlike the existing unit tests that spin up a local HTTP server that mimics certain behavior of the API, these integration tests will call against the live GitHub API. As such, they will likely take a lot longer to execute and will not be run near as often. I've set things up with aff0a13 and will continue working from there.
I'm not 100% settled yet on how extensive these tests need to be. For example, we don't need to test the value of every field in a response. The biggest goal is to have a test suite that can be run when things like the default media type changes to make sure the library is still working properly. I also have a separate test suite that I'm working on to identify fields in responses that we aren't mapping into our Go structs.
The text was updated successfully, but these errors were encountered: