The Wayback Machine - https://web.archive.org/web/20211120105449/https://github.com/TheAlgorithms/Python/issues/5434
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate repeated is_prime functions #5434

Open
poyea opened this issue Oct 19, 2021 · 4 comments
Open

Deduplicate repeated is_prime functions #5434

poyea opened this issue Oct 19, 2021 · 4 comments
Assignees
@poyea
Labels
good first issue help wanted

Comments

@poyea
Copy link
Member

@poyea poyea commented Oct 19, 2021 •
edited
Loading

We have a lot of is_prime (or similar) functions: https://github.com/TheAlgorithms/Python/search?p=4&q=is_prime, https://github.com/TheAlgorithms/Python/search?q=isPrime, data_structures/hashing/number_theory/prime_numbers, etc. Shall we use one common function for that exactly identical is_prime calculation (which takes O(sqrt(n)))?

Candidates include:
@poyea poyea self-assigned this Oct 19, 2021
@srishtik2310
Copy link
Contributor

@srishtik2310 srishtik2310 commented Oct 19, 2021

Can you assign this to me.

Loading

@murilo-goncalves
Copy link
Contributor

@murilo-goncalves murilo-goncalves commented Oct 20, 2021

I will do it!

Loading

@murilo-goncalves murilo-goncalves mentioned this issue Oct 20, 2021
Closed
14 tasks
@poyea poyea mentioned this issue Oct 22, 2021
Merged
14 tasks
@VaishnaviJahagirdar3
Copy link

@VaishnaviJahagirdar3 VaishnaviJahagirdar3 commented Oct 28, 2021

Hi! I'm interested in working on this

Loading

@Gyan-Singh
Copy link

@Gyan-Singh Gyan-Singh commented Oct 28, 2021

Can I try solve this prob?

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@poyea poyea

Labels
good first issue help wanted
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

Fix: deduplicated "is_prime" functions
5 participants
@poyea @murilo-goncalves @srishtik2310 @VaishnaviJahagirdar3 @Gyan-Singh