The Wayback Machine - https://web.archive.org/web/20211123023510/https://github.com/matplotlib/matplotlib/pull/20873
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove mplutils.cpp; shorten mplutils.h. #20873

Merged
merged 1 commit into from Aug 21, 2021
Merged

Conversation

@anntzer
Copy link
Contributor

@anntzer anntzer commented Aug 21, 2021

mplutils.cpp only provides add_dict_int, which (for us) can be replaced
by PyModule_AddIntConstant (already used in the same fashion in
image_wrapper.cpp).

MAX and CLAMP can be replaced via std::max/std::min, as they are only
used in C++ modules.

PR Summary

PR Checklist

  • Has pytest style unit tests (and pytest passes).
  • Is Flake 8 compliant (run flake8 on changed files to check).
  • New features are documented, with examples if plot related.
  • Documentation is sphinx and numpydoc compliant (the docs should build without error).
  • Conforms to Matplotlib style conventions (install flake8-docstrings and run flake8 --docstring-convention=all).
  • New features have an entry in doc/users/next_whats_new/ (follow instructions in README.rst there).
  • API changes documented in doc/api/next_api_changes/ (follow instructions in README.rst there).
mplutils.cpp only provides add_dict_int, which (for us) can be replaced
by PyModule_AddIntConstant (already used in the same fashion in
image_wrapper.cpp).

MAX and CLAMP can be replaced via std::max/std::min, as they are only
used in C++ modules.
@tacaswell tacaswell merged commit 67d04a8 into matplotlib:master Aug 21, 2021
27 checks passed
Loading
@tacaswell tacaswell added this to the v3.5.0 milestone Aug 21, 2021
@anntzer anntzer deleted the mplutils branch Aug 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants