dart-lang / sdk Public

Bug: #48728
Change-Id: Ie73f384c619bf90a502933d544e10b598b5c11cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239841
Reviewed-by: Brian Wilkerson <[email protected]>
Reviewed-by: Samuel Rawlins <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

BUG=#48721
TEST=file_error2_test,file_fuzz_test on win ia32

Change-Id: I260c3fa46bc737db741b3b9ae9172c939648aa6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239861
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>

Fixes #48717

Change-Id: I45145bc992bb129d54962b1ed9cfebbdbac41f92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239730
Reviewed-by: Nicholas Shahan <[email protected]>
Commit-Queue: Mark Zhou <[email protected]>

…me they arrived

Hopefully fixes Dart-Code/Dart-Code#3892.

Change-Id: I311c7856b01c3c674aaae2568774f88266f015a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239422
Reviewed-by: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

These are now enforced in pkg/js_ast so we don't need to worry about
introducing unwanted diffs between the forked versions.

Change-Id: I89efc97f53a433f98e2a06747690ac7a635c388d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239560
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

…generic super type.

Bug: #48727
Change-Id: I942551bf51fdbeeba8824ee8bd43676c79136d41
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239840
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Change-Id: I187c547d9922185dd20db3e773eb4c8fbe7ec0a6
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239544
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

Change-Id: I89826ba3af91f1392d6291b008b41af94c0072b1
Issue: #46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239585
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

Enforcing these lints helps reduce the diffs with the forked version
in pkg/dev_compiler/lib/src/js_ast.

Enforce extra lints:
- always_declare_return_types
- depend_on_referenced_packages
- directives_ordering
- prefer_single_quotes
- prefer_relative_imports

Add ignores for:
- avoid_function_literals_in_foreach_calls
- avoid_renaming_method_parameters
- constant_identifier_names
- non_constant_identifier_names
- prefer_void_to_null

Change-Id: I6b96eca51fdb698927569df538d1db1bf07498cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239325
Reviewed-by: Stephen Adams <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

Fixes #48479

Change-Id: I8953c0917331883d12050feb7dc03a32654f61df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239669
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Fixes #48405

TEST=N/A

Change-Id: I975d713d27fac6221e3a06dce0cddaf1f5019b7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239583
Reviewed-by: Devon Carew <[email protected]>
Commit-Queue: Ben Konyi <[email protected]>

Bug: #48724
Change-Id: If6e8bb61e02066bbdd9b209b8dcd569b98c57e3c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239736
Commit-Queue: Konstantin Shcheglov <[email protected]>
Reviewed-by: Brian Wilkerson <[email protected]>

Fixes #48626

Change-Id: Ie0b7d1e8f92ab5ecfc03e60635ab89ea4b99f0d3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239432
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Addresses #48725
TEST=ci

Change-Id: I34a8c974c88e6047de01d431f687e187b6d294a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239820
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>

Fixes flutter/devtools#3571.

Change-Id: I168b44ef0e59a16695ce824499dff774ba46f3d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239800
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Kenzie Davisson <[email protected]>

When I was using it for passing large Uint8List(s) (e.g. 50 MB),
using setRange() is faster (IIRC about 2x).

Change-Id: I7ade61fe8cd8f0f709b2e917e5ea2c2e97fb0d16
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239729
Reviewed-by: Jake Macdonald <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

Fixes some issues with resolving SDK build dirs on M1 Macs, as some of our tooling implicitly builds DebugX64.

Change-Id: Ia890bbe2b552be5eaa6207fc5f930c0b0e7c4ffa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239731
Reviewed-by: William Hesse <[email protected]>
Commit-Queue: Mark Zhou <[email protected]>

Change-Id: I211f3c3a029a9fd16a1ca485fd62b62c2f6b1d43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239584
Reviewed-by: Kenzie Davisson <[email protected]>

Change-Id: I1034632eea288cbf5fa932eee279984cc67c5ed4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239701
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

The updates the messaging for when experimental features are not
enabled to take into account whether the feature has been released
and whether an explicit or implicit language version opt out the
feature.

Change-Id: I77c31e7e327d1beca2dd4a82dbaf648711894e7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239663
Reviewed-by: Chloe Stefantsova <[email protected]>
Commit-Queue: Johnni Winther <[email protected]>

…rted with no error"

This reverts commit dc8002c.

Reason for revert: crashes internally (b/227727791) and externally (dartbug.com/48721)

Original change's description:
> [VM / IO] - Reland : Assert when an OSError exception is reported with no error
>
> 1. Add a Fatal assert when an OSError is reported with no error code (0).
> This is to ensure we get a coredum pwhen this happens so we can analyze
> it. (Please see flutter/flutter#90921 for more
> details)
>
> TEST=ci
>
> Change-Id: I7146ac69ef8b1833f28bed8a23f0c27a2ece4bbf
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239726
> Reviewed-by: Alexander Aprelev <[email protected]>
> Commit-Queue: Siva Annamalai <[email protected]>

[email protected],[email protected]

Change-Id: Ic9302e7922b0ce2ea5ab81357804c3cd822a8052
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239664
Reviewed-by: Slava Egorov <[email protected]>
Bot-Commit: Rubber Stamper <[email protected]>
Commit-Queue: Slava Egorov <[email protected]>

Change-Id: I2fc4bfc8f9f43ae379cfc590c4dc4d6765a493de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239732
Commit-Queue: Mark Zhou <[email protected]>
Reviewed-by: Bob Nystrom <[email protected]>
Commit-Queue: Bob Nystrom <[email protected]>

When an unexpected "Undetermined Nullability" is encountered the
compiler will throw a message that contains the library being
compiled and the problematic type.

Change-Id: I0d6c3335b8c207b0344354dc4e9a2d7152571b12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239722
Reviewed-by: Mark Zhou <[email protected]>
Commit-Queue: Nicholas Shahan <[email protected]>

…h no error

1. Add a Fatal assert when an OSError is reported with no error code (0).
This is to ensure we get a coredum pwhen this happens so we can analyze
it. (Please see flutter/flutter#90921 for more
details)

TEST=ci

Change-Id: I7146ac69ef8b1833f28bed8a23f0c27a2ece4bbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239726
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Siva Annamalai <[email protected]>

…-formal.

Bug: #48719
Change-Id: I7ecf986e17c21bfe010a97d482a0ce30891ccfc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239728
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Konstantin Shcheglov <[email protected]>

PP is a volatile register on RISC-V to take advantage of compressed instructions, and a preserved register on the other architectures.

TEST=ffi_2/function_structs_test
Bug: #48164
Change-Id: I947d6fd8171b8c0c7aa8eb524537038655177e27
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238720
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>

Fixes #47581

Change-Id: I0e412253010d8c9bbafb74ecb0662239e5a0c0dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239304
Reviewed-by: Brian Wilkerson <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

This commit is also being rolled internally in advance of the SDK roll
to allow publishing sooner. This rolls to a commit past an earlier
attempt which needed to be reverted due to a test failure which now has
a workaround.

[email protected]

Change-Id: I0056065cadf951f2eb3cbf4094f22df92608388e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239727
Auto-Submit: Nate Bosch <[email protected]>
Commit-Queue: Nate Bosch <[email protected]>
Reviewed-by: Jake Macdonald <[email protected]>
Commit-Queue: Jake Macdonald <[email protected]>

Change-Id: Ic90d39dbbc059a4beb0ece1886a05e9af627886f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239724
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

Change-Id: I957a2a84ac7c8fdebc1fce80dccf4716964f5647
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239761
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

…er than errno.

Fixes #48718
TEST=file_test

Change-Id: Ie47fa7807b96832140e8b9d5df53b47ffa0ecc67
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239725
Reviewed-by: Siva Annamalai <[email protected]>
Commit-Queue: Alexander Aprelev <[email protected]>

Change-Id: I3ab699824f30999e85e747183983e372b17653d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239400
Reviewed-by: Konstantin Shcheglov <[email protected]>
Commit-Queue: Brian Wilkerson <[email protected]>

TEST=ci
Change-Id: I58187fc89aa3be935e70dbdd2316b17aadf50574
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239465
Reviewed-by: Ben Konyi <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>

Part of #47453

Change-Id: I376b309e019a1e18444613f14c9e8870c0f10eb6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239681
Reviewed-by: Johnni Winther <[email protected]>
Commit-Queue: Chloe Stefantsova <[email protected]>

Cf. cb64a64.

 - Fix misaligned stack during some callouts.
 - Fix clobbered PP during some callouts.

TEST=vmspecific_handle_test
Bug: #48164
Change-Id: I4650219e96f8592bf7e1790f9ff0b71c109c1ff6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239760
Reviewed-by: Alexander Aprelev <[email protected]>
Commit-Queue: Ryan Macnak <[email protected]>