The Wayback Machine - https://web.archive.org/web/20231211135219/https://github.com/SeleniumHQ/selenium/pull/10075
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove legacy in favour of W3C endpoints. #10075

Merged
merged 2 commits into from Nov 30, 2021
Merged

Remove legacy in favour of W3C endpoints. #10075

merged 2 commits into from Nov 30, 2021

Conversation

dosas
Copy link
Contributor

@dosas dosas commented Nov 23, 2021 •
edited

Thanks for contributing to Selenium!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@dosas dosas mentioned this pull request Nov 23, 2021
Closed
@codecov-commenter
Copy link

Codecov Report

Merging #10075 (ea8d30a) into trunk (d7dfe5e) will decrease coverage by 0.09%.
The diff coverage is n/a.

❗ Current head ea8d30a differs from pull request most recent head a4116df. Consider uploading reports for the commit a4116df to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##            trunk   #10075      +/-   ##
==========================================
- Coverage   44.91%   44.82%   -0.10%     
==========================================
  Files          84       84              
  Lines        5597     5571      -26     
  Branches      259      259              
==========================================
- Hits         2514     2497      -17     
+ Misses       2824     2815       -9     
  Partials      259      259
Impacted Files Coverage Δ
py/selenium/webdriver/remote/command.py 100.00% <ø> (ø)
py/selenium/webdriver/remote/remote_connection.py 35.26% <ø> (-0.56%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c2e844...a4116df. Read the comment docs.

@AutomatedTester AutomatedTester merged commit fc66324 into SeleniumHQ:trunk Nov 30, 2021
@sonarcloud
Copy link

sonarcloud bot commented Nov 30, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@dosas @AutomatedTester @elgatov
Remove legacy in favour of W3C endpoints. (SeleniumHQ#10075)
b0818fa 
Co-authored-by: dosas <[email protected]>
Co-authored-by: David Burns <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AutomatedTester AutomatedTester AutomatedTester approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dosas @codecov-commenter @AutomatedTester