[py] Fix RelativeBy near() docs, fix bugs and deprecations in webserver.py
#10077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactored the webserver.py code to use some modern python language features and changed invocations of deprecated functions in the stop() method. Running webserver.py now directly works as a bug in the script forced both host and port to be the port.
|
|
symonk
changed the title
above() docs, fix bugs and deprecations in webserver.py
symonk
changed the title
above() docs, fix bugs and deprecations in webserver.pynear() docs, fix bugs and deprecations in webserver.py
symonk
commented
Nov 23, 2021
| default=DEFAULT_PORT) | ||
|
|
||
| opts, args = parser.parse_args(argv[1:]) | ||
| if args: | ||
| parser.error("wrong number of arguments") # Will exit | ||
|
|
||
| server = SimpleWebServer(opts.port) | ||
| server = SimpleWebServer(port=opts.port) |
There was a problem hiding this comment.
was mistakenly setting the host= as the port.
symonk
changed the title
near() docs, fix bugs and deprecations in webserver.pynear() docs, fix bugs and deprecations in webserver.py
AutomatedTester
approved these changes
Nov 30, 2021
Codecov Report
@@ Coverage Diff @@
## trunk #10077 +/- ##
=======================================
Coverage 44.87% 44.87%
=======================================
Files 86 86
Lines 5676 5676
Branches 263 263
=======================================
Hits 2547 2547
Misses 2866 2866
Partials 263 263
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed!
|
elgatov
pushed a commit
to elgatov/selenium
that referenced
this pull request
Jun 27, 2022
SeleniumHQ#10077) Refactored the webserver.py code to use some modern python language features and changed invocations of deprecated functions in the stop() method. Running webserver.py now directly works as a bug in the script forced both host and port to be the port. Co-authored-by: David Burns <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed up a discrepency when invoking webserver.py standalone where host was set as the port number provided. Tidied up some of the webserver code was I was in there and stopped called a deprecated function in the
stop()method of theSimpleWebServerTypes of changes
Checklist