The Wayback Machine - https://web.archive.org/web/20231208162713/https://github.com/SeleniumHQ/selenium/pull/10081
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[java] Fix #10080 Handle null parameters in TracedCommandExecutor #10081

Merged
merged 2 commits into from Dec 1, 2021
Merged

[java] Fix #10080 Handle null parameters in TracedCommandExecutor #10081

merged 2 commits into from Dec 1, 2021

Conversation

BorisOsipov
Copy link
Contributor

@BorisOsipov BorisOsipov commented Nov 24, 2021 •
edited

Description

Bug fix for #10080
Converts null param value to "null" string.

Closes #10080

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Nov 24, 2021 •
edited

CLA assistant check
All committers have signed the CLA.

@BorisOsipov BorisOsipov force-pushed the #10080-fix-npe branch 2 times, most recently from bc4d189 to 38445b8 Compare November 24, 2021 17:20
@BorisOsipov
Copy link
Contributor Author

Test failures seems unrelated to this changes

diemol
diemol approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @BorisOsipov! Congrats on your first contribution! 🎉

Thank you for your help reviewing @dacloutier-logmein!

@diemol diemol merged commit 07dfc77 into SeleniumHQ:trunk Dec 1, 2021
@sonarcloud
Copy link

sonarcloud bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@pkoenig10
Copy link

When can we expect a new release with this fix?

@diemol diemol mentioned this pull request Dec 10, 2021
Closed
elgatov pushed a commit to elgatov/selenium that referenced this pull request Jun 27, 2022
@BorisOsipov @diemol @elgatov
[java] Handle null parameters in TracedCommandExecutor (SeleniumHQ#10081
9c6cb6d 
)

Co-authored-by: Diego Molina <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@diemol diemol diemol approved these changes

@dacloutier-logmein dacloutier-logmein dacloutier-logmein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: TracedCommandExecutor throws NPE for driver.switchTo().defaultContent() method for RemoteWebDriver
5 participants
@BorisOsipov @CLAassistant @pkoenig10 @diemol @dacloutier-logmein