The Wayback Machine - https://web.archive.org/web/20211215150901/https://github.com/dotnet/aspnetcore/pull/25749
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use VS from env if specified #25749

Merged
merged 1 commit into from Sep 10, 2020
Merged

Use VS from env if specified #25749

merged 1 commit into from Sep 10, 2020

Conversation

@Pilchie
Copy link
Member

@Pilchie Pilchie commented Sep 9, 2020

No description provided.

Copy link
Member

@dougbu dougbu left a comment

When would %VSINSTALLDIR% be defined and what problem does using it solve

Loading

@Pilchie
Copy link
Member Author

@Pilchie Pilchie commented Sep 10, 2020

When would %VSINSTALLDIR% be defined

If you run startvs from a VS command/Powershell prompt

what problem does using it solve

Makes startvs start the VS you want it to if you have multiple installed.

Loading

dougbu
dougbu approved these changes Sep 10, 2020
Copy link
Member

@dougbu dougbu left a comment

Sounds good

Loading

@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Sep 10, 2020

Hello @Pilchie!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

Loading

@Pilchie
Copy link
Member Author

@Pilchie Pilchie commented Sep 10, 2020

Merging since this change isn't used in the build, and the test that failed is quarantined in release/5.0-rc2

Loading

@Pilchie Pilchie merged commit d7c1d51 into dotnet:master Sep 10, 2020
21 of 23 checks passed
Loading
@Pilchie Pilchie deleted the startvs branch Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants