The Wayback Machine - https://web.archive.org/web/20220131204438/https://github.com/angular/angular/pull/27979
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: remove remaining travis leftovers #27979

Closed

Conversation

@devversion
Copy link
Member

@devversion devversion commented Jan 8, 2019

  • There still seem to be a few TravisCI leftovers which can be removed now.
  • Also fixes that a few e2e tests aren't running. These have been disabled a long time ago, but can be re-enabled now.
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Jan 8, 2019

@devversion devversion force-pushed the chore/remove-travis-leftovers branch from 4d73686 to f4d4e7b Jan 8, 2019
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Jan 8, 2019

devversion added 2 commits Jan 8, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.
@mary-poppins
Copy link

@mary-poppins mary-poppins commented Jan 8, 2019

gkalpak
gkalpak approved these changes Jan 8, 2019
Copy link
Contributor

@IgorMinar IgorMinar left a comment

thanks!

@IgorMinar
Copy link
Contributor

@IgorMinar IgorMinar commented Jan 9, 2019

@IgorMinar
Copy link
Contributor

@IgorMinar IgorMinar commented Jan 9, 2019

caretaker note: pending review check is invalid because the PR has global approver approval

@ocombe this is a good example of when robot should not complain about pending reviews.

@ocombe
Copy link
Contributor

@ocombe ocombe commented Jan 9, 2019

I removed the merge-assistance label as the bot is now able to ignore team review requests.

AndrewKushnir added a commit that referenced this issue Jan 9, 2019
AndrewKushnir added a commit that referenced this issue Jan 9, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
AndrewKushnir added a commit that referenced this issue Jan 9, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
AndrewKushnir added a commit that referenced this issue Jan 16, 2019
AndrewKushnir added a commit that referenced this issue Jan 16, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close #27979
ngfelixl added a commit to ngfelixl/angular that referenced this issue Jan 28, 2019
ngfelixl added a commit to ngfelixl/angular that referenced this issue Jan 28, 2019
Re-enables a few e2e tests which have been disabled a long time ago. Since these pass now, we should re-enable them.

PR Close angular#27979
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Sep 14, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants