Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Complete inner Pipewriter in HttpLoggingMiddleware #39989
+541
−350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
reviewed
Feb 4, 2022
| _bufferingWriter = new BufferingWriter(); | ||
| } | ||
|
|
||
| public override bool CanSeek => _innerStream.CanSeek; |
There was a problem hiding this comment.
Most of the changes to this file & ResponseBufferingStream are moving the Stream overrides from BufferingStream (now BufferingWriter) to these 2 files which now inherit from Stream
Tratcher
reviewed
Feb 4, 2022
| { | ||
| if (_pipeWriter != null) | ||
| { | ||
| await _pipeWriter.CompleteAsync(); |
There was a problem hiding this comment.
Why Complete rather than just Flush?
There was a problem hiding this comment.
In case someone else has already completed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Fixes #39317. When replacing the Body feature in
HttpLoggingMiddlewarewith a newIHttpResponseBodyFeaturethat wraps the original PipeWriter used by gRPC (or whoever), the implicit flush that happens in Kestrel doesn't wind up flushing the original PipeWriter. This causes Responses sent by gRPC to be silently swallowed. Instead we explicitly complete the original PipeWriter after receiving the response.Still thinking about how to add a test for this.
Also adds new API to allow completing the PipeWriter on a StreamResponseBodyFeature:
public class StreamResponseBodyFeature { + public async Task CompleteWriterAsync() }The text was updated successfully, but these errors were encountered: