The Wayback Machine - https://web.archive.org/web/20211121094440/https://github.com/go-gitea/gitea/pull/15073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[refactor] Use i18n.Reset to reload locales #15073

Merged

6543 merged 7 commits into go-gitea:master from 6543-forks:only_i18n-flush

Mar 21, 2021

Member

6543 commented Mar 20, 2021 •

edited

Loading

Follow up of #14582, by using Reset()

6543 added 2 commits


          Use i18n fork to get Flush() func

be7f26e


          Use i18n.Flush to reload locales

0ee5304

6543 added the kind/refactor label

6543 added this to the 1.15.0 milestone

6543 mentioned this pull request

Set default language to first element of LANGS #14846

Closed

Member Author

6543 commented Mar 20, 2021

PS: need gomod replace since unknwon/i18n#9 got not merged jet :/

GiteaBot added the lgtm/need 2 label

6543 added 2 commits


          make linter happy

90fec55


          Merge branch 'master' into only_i18n-flush

286c1d0

zeripath approved these changes

GiteaBot added lgtm/need 1 and removed lgtm/need 2 labels


          Merge branch 'master' into only_i18n-flush

da186b7

lunny approved these changes

Member

lunny left a comment

Except I think the function name Flush should be Reset.

GiteaBot added lgtm/done and removed lgtm/need 1 labels

6543 added the status/blocked label

6543 mentioned this pull request

Add Reset() unknwon/i18n#9

Merged

Member Author

6543 commented Mar 21, 2021

look's like upstream get merged soon - so lets wait :)

6543 changed the title ~~[refactor] Use i18n.Flush to reload locales~~ [refactor] Use i18n.Reset to reload locales


          upstream got merged

77b7892

6543 reviewed

modules/translation/translation.go Outdated Show resolved Hide resolved


          Update modules/translation/translation.go

87ffe8b

6543 removed the status/blocked label

Member Author

6543 commented Mar 21, 2021

🚀

6543 merged commit 24f7bd5 into go-gitea:master

2 checks passed

6543 deleted the only_i18n-flush branch

go-gitea locked and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.