Create Proper Migration tests #15116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
zeripath
changed the title
|
OK it's wired in.. The structure is a bit of a hack with the current inferior migration tests still being run from integrations/migration-test - these should probably be either moved in to migrations as proper tests or just removed once we have enough tests to be happy that they are no longer needed. |
zeripath
reviewed
Mar 22, 2021
zeripath
reviewed
Mar 22, 2021
|
Oh that's interesting there's a bug with drop table columns on mssql ... |
6543
approved these changes
Mar 23, 2021
Unfortunately our testing regime has so far meant that migrations do not get proper testing. This PR begins the process of creating migration tests for this. Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
Signed-off-by: Andrew Thornton <[email protected]>
kdumontnu
approved these changes
Mar 24, 2021
Thanks for adding these!
Do you think it would be good practice to add a comment block at the top of v176_test.go and v177_test.go to explain at high level what the migrations intend to do? Ex. "create index X", etc.
|
I think such comments would probably be better on the migration functions themselves. |
Signed-off-by: Andrew Thornton <[email protected]>
6543
approved these changes
Mar 24, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Unfortunately our testing regime has so far meant that migrations do not
get proper testing.
This PR begins the process of creating migration tests for this.
Signed-off-by: Andrew Thornton [email protected]