The Wayback Machine - https://web.archive.org/web/20211121094446/https://github.com/go-gitea/gitea/pull/15229
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

response simple text message for not html request when 404 #15229

Merged
merged 3 commits into from Apr 1, 2021
Merged

response simple text message for not html request when 404 #15229

merged 3 commits into from Apr 1, 2021

Conversation

@a1012112796
Copy link
Member

@a1012112796 a1012112796 commented Apr 1, 2021 •
edited
Loading

example view:

tmp
@a1012112796 a1012112796 changed the title response simple text message for not html request when response 404 response simple text message for not html request when 404 Apr 1, 2021
lunny
lunny approved these changes Apr 1, 2021
View changes
@lafriks
Copy link
Member

@lafriks lafriks commented Apr 1, 2021

Can't we just check strings.Contains for text/html?

Loading

@techknowlogick techknowlogick added this to the 1.15.0 milestone Apr 1, 2021
6543
6543 approved these changes Apr 1, 2021
View changes
@6543
Copy link
Member

@6543 6543 commented Apr 1, 2021

.

Loading

@6543 6543 merged commit 43fb492 into go-gitea:master Apr 1, 2021
2 checks passed
Loading
@a1012112796 a1012112796 deleted the simple-404 branch Apr 1, 2021
@go-gitea go-gitea locked and limited conversation to collaborators May 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny

@6543 6543

Assignees
No one assigned
Labels
kind/enhancement lgtm/done
Milestone
1.15.0
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants
@a1012112796 @lafriks @6543 @lunny @techknowlogick @GiteaBot