SHA in merged commit comment should be rendered ui sha #15376
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On a PR page the sha of the merge commit should be rendered in monospace as a SHA. Also fixes an issue with the manually merged string. Fix go-gitea#15049 Signed-off-by: Andrew Thornton <[email protected]>
|
This is a difficult one. Ideally it would be backported but then we'd need to change the locale strings too. |
silverwind
approved these changes
Apr 9, 2021
|
Hmm it might be possible to fix all translations with some |
|
There might be more similar cases, I'm not sure. |
ugh let me look again. - No this one is not a SHA |
|
|
Signed-off-by: Andrew Thornton <[email protected]>
|
yup agreed |
|
Can't find any more. |
techknowlogick
approved these changes
Apr 9, 2021
lunny
approved these changes
Apr 10, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
On a PR page the sha of the merge commit should be rendered in monospace
as a SHA. Also fixes an issue with the manually merged string and issues.force_push_codes
Fix #15049
Signed-off-by: Andrew Thornton [email protected]