Open the DingTalk link in browser #17084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wxiaoguang please update the test code. |
Codecov Report
@@ Coverage Diff @@
## main #17084 +/- ##
==========================================
- Coverage 45.27% 45.23% -0.04%
==========================================
Files 771 771
Lines 86767 86767
==========================================
- Hits 39285 39253 -32
- Misses 41130 41165 +35
+ Partials 6352 6349 -3
Continue to review full report at Codecov.
|
|
Unit tests are fixed. |
KN4CK3R
approved these changes
Sep 18, 2021
lunny
approved these changes
Sep 18, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
https://developers.dingtalk.com/document/app/message-link-description
To open the link in browser, we should use this URL:
"dingtalk://dingtalkclient/page/link?pc_slide=false&url=" + url.QueryEscape(singleURL)Otherwise the page is displayed inside DingTalk client, it makes users very difficult to visit non-public URLs in DingTalk webhook messages.
The patch is tested and it works as expected.
The text was updated successfully, but these errors were encountered: