The Wayback Machine - https://web.archive.org/web/20220213042224/https://github.com/libigl/libigl/pull/1970
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ImGui to v1.85 + use default include folders. #1970

Merged
merged 1 commit into from Feb 11, 2022
Merged

Update ImGui to v1.85 + use default include folders. #1970

merged 1 commit into from Feb 11, 2022

Conversation

@jdumas
Copy link
Collaborator

@jdumas jdumas commented Feb 11, 2022

Updates CMake code to use the repo imgui and imguizmo as the only include path. This avoids the hack of copying headers around and makes libigl code compatible with other codebase including imgui in their own projects.

Client code using ImGuiMenu.h should not need to include imgui.h (since it's already included by ImGuiMenu.h), but if they do, the following modifications would be required:

  • #include <imgui/imgui.h> --> #include <imgui.h>
  • #include <imgui/imgui_internal.h> --> #include <imgui_internal.h>
  • #include <imgui_impl_glfw.h> --> #include <backends/imgui_impl_glfw.h>
  • #include <imgui_impl_opengl3.h> --> #include <backends/imgui_impl_opengl3.h>
@jdumas jdumas added this to the v2.4.0 milestone Feb 11, 2022
@jdumas jdumas added this to In progress in Viewer module via automation Feb 11, 2022
@jdumas jdumas added this to In progress in Infrastructure via automation Feb 11, 2022
@jdumas jdumas force-pushed the jdumas/imgui branch 5 times, most recently from 1c7b29c to 03694da Feb 11, 2022
@jdumas jdumas merged commit 237ffa2 into main Feb 11, 2022
6 checks passed
Infrastructure automation moved this from In progress to Done Feb 11, 2022
@jdumas jdumas deleted the jdumas/imgui branch Feb 11, 2022
Viewer module automation moved this from In progress to Done Feb 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant