In disk_channel queues synchronously push to disk on shutdown (#18415) #18788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ea#18415) Partial Backport of go-gitea#18415 Instead of using an asynchronous goroutine to push to disk on shutdown just close the datachan and immediately push to the disk. Prevents messages of incompletely flushed queues. Signed-off-by: Andrew Thornton <[email protected]>
lunny
approved these changes
Feb 20, 2022
silverwind
approved these changes
Feb 22, 2022
|
make L-G-T-M work |
zjjhot
added a commit
to zjjhot/gitea
that referenced
this issue
Feb 22, 2022
…se/v1.16 * giteaofficial/release/v1.16: In disk_channel queues synchronously push to disk on shutdown (go-gitea#18415) (go-gitea#18788) Fix bug for get user by email (go-gitea#18834) Update go-org to 1.6.0 (go-gitea#18824) (go-gitea#18839) Show fullname on issue edits and gpg/ssh signing info (go-gitea#18828) Put buttons back in org dashboard (go-gitea#18817) (go-gitea#18825) Immediately Hammer if second kill is sent (go-gitea#18823) (go-gitea#18826) Fix panic in EscapeReader (go-gitea#18820) (go-gitea#18821) remove redundant call to UpdateRepoStats during migration (go-gitea#18591) (go-gitea#18794) Allow mermaid render error to wrap (go-gitea#18791) Attempt to fix the webauthn migration again - part 3 (go-gitea#18770) (go-gitea#18771) Fix template bug of LFS lock (go-gitea#18784) (go-gitea#18787) Various Mermaid improvements (go-gitea#18776) (go-gitea#18780) Ensure git tag tests and others create test repos in tmpdir (go-gitea#18447) (go-gitea#18767) Increase the size of the webauthn_credential credential_id field (go-gitea#18739) (go-gitea#18756) Prevent dangling GetAttribute calls (go-gitea#18754) (go-gitea#18755) Send mail to issue/pr assignee/reviewer also when OnMention is set (go-gitea#18707) (go-gitea#18765) Fix a broken link in `commits_list_small.tmpl` (go-gitea#18764) Fix isempty detection of git repository (go-gitea#18746) (go-gitea#18750)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Partial Backport of #18415
Instead of using an asynchronous goroutine to push to disk on shutdown
just close the datachan and immediately push to the disk.
Prevents messages of incompletely flushed queues.
Signed-off-by: Andrew Thornton [email protected]