The Wayback Machine - https://web.archive.org/web/20210730002334/https://github.com/dotnet/aspnetcore/issues/34864
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logging site extension should use startup hooks (instead of additional deps) #34864

Open
shirhatti opened this issue Jul 30, 2021 · 0 comments
Open

Comments

@shirhatti
Copy link
Member

@shirhatti shirhatti commented Jul 30, 2021

The AzureAppServiceLoggingSiteExtension relies on the DOTNET_ADDITIONAL_DEPS feature in the host. This results in an error-prone process where we forget to add a new runtime store directory for older tfms when we update the repo's default tfm.

Given that 2.1 will go out of support soon, we will no longer need to support a version of .NET that doesn't have startup hooks. This will allow us to switch to a version agnostic implementation using startup hooks that will no longer require us to update the SiteExtension every time we add a tfm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant