Support binding parameters to type Uri in Minimal Actions #36649

martincostello · 2021-09-17T14:26:50Z

Is your feature request related to a problem? Please describe.

In MVC controllers actions, it is possible to strongly-type a parameter expected to be a URI as Uri. For example:

public IActionResult MyAction([FromQuery(Name = "redirect_uri")] Uri? redirectUri)
{
    // Implementation
}

However, attempting to replicate this with a Minimal Action endpoint results in an exception being thrown.

app.MapGet("/my-action", ([FromQuery(Name = "redirect_uri")] Uri? redirectUri) =>
{
    // Implementation
});

  Message: 
System.InvalidOperationException : No public static bool Uri.TryParse(string, out Uri) method found for redirectUri.

  Stack Trace: 
RequestDelegateFactory.BindParameterFromValue(ParameterInfo parameter, Expression valueExpression, FactoryContext factoryContext)
RequestDelegateFactory.CreateArgument(ParameterInfo parameter, FactoryContext factoryContext)
RequestDelegateFactory.CreateArguments(ParameterInfo[] parameters, FactoryContext factoryContext)
RequestDelegateFactory.CreateTargetableRequestDelegate(MethodInfo methodInfo, RequestDelegateFactoryOptions options, FactoryContext factoryContext, Expression targetExpression)
RequestDelegateFactory.Create(Delegate handler, RequestDelegateFactoryOptions options)
DelegateEndpointRouteBuilderExtensions.Map(IEndpointRouteBuilder endpoints, RoutePattern pattern, Delegate handler)
DelegateEndpointRouteBuilderExtensions.MapMethods(IEndpointRouteBuilder endpoints, String pattern, IEnumerable`1 httpMethods, Delegate handler)
DelegateEndpointRouteBuilderExtensions.MapGet(IEndpointRouteBuilder endpoints, String pattern, Delegate handler)

Describe the solution you'd like

Either of:

Minimal Actions (RequestDelegateFactory) special-cases Uri to bind parameters;
Minimal Actions supports extending model binding for types not owned by the application where a TryParse or BindAsync method cannot be added;
The Uri type adds a TryParse() method that can be consumed by the built-in binding.

Additional context

Found using .NET SDK 6.0.100-rc.1.21458.32 to port an existing MVC application to use Minimal Actions.

The text was updated successfully, but these errors were encountered:

davidfowl · 2021-09-17T14:41:34Z

Yes this is because MVC supports TypeConverters natively. We could choose to do this as well but there are some concerns around that subsystem and AOT friendliness. If we did this, we would support Uri natively or support it via TypeConverter.

rafikiassumani-msft · 2021-09-17T17:23:36Z

We will revisit this in NET7. We might examine the following suggestion: The Uri type adds a TryParse() method that can be consumed by the built-in binding.

davidfowl added this to Ready in Minimal APIs 6.0 via automation Sep 17, 2021

davidfowl added the feature-minimal-actions label Sep 17, 2021

rafikiassumani-msft added the area-web-frameworks label Sep 17, 2021

rafikiassumani-msft moved this from Ready to Need review in Minimal APIs 6.0 Sep 17, 2021

rafikiassumani-msft removed this from Need review in Minimal APIs 6.0 Sep 17, 2021

rafikiassumani-msft added this to the .NET 7 Planning milestone Sep 17, 2021

Aug	SEP	Oct
	18
2020	2021	2022

dotnet / aspnetcore Public

Support binding parameters to type Uri in Minimal Actions #36649

Support binding parameters to type Uri in Minimal Actions #36649

martincostello commented Sep 17, 2021

davidfowl commented Sep 17, 2021

rafikiassumani-msft commented Sep 17, 2021

dotnet / aspnetcore Public

Support binding parameters to type Uri in Minimal Actions #36649

Support binding parameters to type Uri in Minimal Actions #36649

Comments

martincostello commented Sep 17, 2021

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Additional context

davidfowl commented Sep 17, 2021

rafikiassumani-msft commented Sep 17, 2021