The Wayback Machine - https://web.archive.org/web/20211104230022/https://github.com/dotnet/aspnetcore/pull/38094
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SocketException usage #38094

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Remove SocketException usage #38094

wants to merge 3 commits into from

Conversation

Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sebastienros
Copy link
Member

@sebastienros sebastienros commented Nov 4, 2021

For review only. Not sure which benchmark would be impacted. It appears clearly in connection close, but there are other bottlenecks in this benchmark that make the change insignificant.


public readonly int BytesTransferred;

public readonly bool HasError;
Copy link
Contributor

@BrennanConroy BrennanConroy Nov 4, 2021

You can infer this by checking if SocketError is null

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment