Minimal APIs doesn't support binding to StringValues from query or headers #36726

davidfowl · 2021-09-19T16:57:14Z

Describe the bug

Parameter binding doesn't support StringValues (which is ASP.NET Core's native representation of both query string and header values).

To Reproduce

using Microsoft.Extensions.Primitives;

var builder = WebApplication.CreateBuilder(args);

var app = builder.Build();

app.MapGet("/", (StringValues query) => query.ToString());

app.Run();

OR

using Microsoft.AspNetCore.Mvc;
using Microsoft.Extensions.Primitives;

var builder = WebApplication.CreateBuilder(args);

var app = builder.Build();

app.MapGet("/", ([FromQuery] StringValues query) => query.ToString());

app.Run();

Exceptions (if any)

The first fails parameter binding things that StringValues is a body parameter.

Unhandled exception. System.InvalidOperationException: Body was inferred but the method does not allow inferred body parameters.
Below is the list of parameters that we found:

Parameter           | Source
---------------------------------------------------------------------------------
query               | Body (Inferred)

Did you mean to register the "Body (Inferred)" parameter(s) as a Service or apply the [FromService] or [FromBody] attribute?

When adding [FromQuery], it also fails but it's because StringValues doesn't have a TryParse method:

Unhandled exception. System.InvalidOperationException: No public static bool StringValues.TryParse(string, out StringValues) method found for query.

It feels bad that our native representation doesn't work...

The text was updated successfully, but these errors were encountered:

davidfowl changed the title ~~We don~~ Minimal APIs doesn't support binding to StringValues from query or headers Sep 19, 2021

davidfowl added the feature-minimal-actions label Sep 19, 2021

davidfowl added this to Ready in Minimal APIs 6.0 via automation Sep 19, 2021

davidfowl added the area-web-frameworks label Sep 19, 2021

rafikiassumani-msft moved this from Ready to Need review in Minimal APIs 6.0 Sep 20, 2021

rafikiassumani-msft removed this from Need review in Minimal APIs 6.0 Sep 20, 2021

rafikiassumani-msft added this to the .NET 7 Planning milestone Sep 20, 2021

Aug	SEP	Dec
	20
2020	2021	2022

dotnet / aspnetcore Public

Minimal APIs doesn't support binding to StringValues from query or headers #36726

Minimal APIs doesn't support binding to StringValues from query or headers #36726

davidfowl commented Sep 19, 2021 •

edited

dotnet / aspnetcore Public

Minimal APIs doesn't support binding to StringValues from query or headers #36726

Minimal APIs doesn't support binding to StringValues from query or headers #36726

Comments

davidfowl commented Sep 19, 2021 • edited

Describe the bug

To Reproduce

Exceptions (if any)

davidfowl commented Sep 19, 2021 •

edited