The Wayback Machine - https://web.archive.org/web/20220125211203/https://github.com/dotnet/aspnetcore/issues/39758
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test failure - "DefaultReconnectionHandler.test - invokes update on each attempt" #39758

Open
JamesNK opened this issue Jan 25, 2022 · 2 comments
Open

Test failure - "DefaultReconnectionHandler.test - invokes update on each attempt" #39758

JamesNK opened this issue Jan 25, 2022 · 2 comments
Labels
area-blazor test-failure

Comments

@JamesNK
Copy link
Member

@JamesNK JamesNK commented Jan 25, 2022

Failing Test(s)

  • DefaultReconnectionHandler.test - invokes update on each attempt

Error Message

FAIL tests/DefaultReconnectionHandler.test.ts (23.354 s)
    ● DefaultReconnectionHandler › invokes update on each attempt
  
      expect(jest.fn()).toHaveBeenCalledTimes(expected)
  
      Expected number of calls: 6
      Received number of calls: 5
  
        90 |
        91 |     await delay(500);
      > 92 |     expect(testDisplay.update).toHaveBeenCalledTimes(maxRetries);
           |                                ^
        93 |
        94 |   })
        95 | });
  
        at Object.<anonymous> (tests/DefaultReconnectionHandler.test.ts:92:32)

Build
@JamesNK
Copy link
Member Author

@JamesNK JamesNK commented Jan 25, 2022

I don't know how to quartine this type of test.

aspnetcore/src/Components/Web.JS/tests/DefaultReconnectionHandler.test.ts

Lines 79 to 94 in 52eff90

it('invokes update on each attempt', async () => {
const testDisplay = createTestDisplay();
const reconnect = jest.fn().mockRejectedValue(null);
const handler = new DefaultReconnectionHandler(NullLogger.instance, testDisplay, reconnect);
const maxRetries = 6;
handler.onConnectionDown({
maxRetries: maxRetries,
retryIntervalMilliseconds: 5,
dialogId: 'ignored'
});
await delay(500);
expect(testDisplay.update).toHaveBeenCalledTimes(maxRetries);
})

@mkArtakMSFT can you please pass this on to someone. This is at least the second time this test has failed in the last couple of days. @BrennanConroy noticed a failure yesterday and included detail in this issue: #39727

@BrennanConroy
Copy link
Member

@BrennanConroy BrennanConroy commented Jan 25, 2022

it.skip('invokes update on each attempt', ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-blazor test-failure
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
@JamesNK @BrennanConroy