The Wayback Machine - https://web.archive.org/web/20220120114514/https://github.com/dotnet/aspnetcore/pull/39649
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch exception in TryConvertTo [updated] #39649

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Catch exception in TryConvertTo [updated] #39649

wants to merge 1 commit into from

Conversation

@SteveSandersonMS
Copy link
Member

@SteveSandersonMS SteveSandersonMS commented Jan 20, 2022

This is a continuation of #33594. I had to create a new PR because the original one was no longer mergeable and further tweaks were needed.

Add test cases for trying to convert valid and invalid GUID values.

Catch exception in TryConvertTo

Catch when the converter throws an exception and return false and set the out value to default.

Change to Guid specific Converter

Remove try/catch added in TryConvertTo  and replace with Guid Converter

Add case for Nullable Guid

Add tests for NullableGuid

Fix NullableGuid parse reflect a null as parsed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants