Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Update SDK to 7.0.100-preview.2.22078.1 #39895
Merged
+16
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtgodbe
approved these changes
Jan 31, 2022
|
@captainsafia the new SDK updates the edit configuration or how it's interpreted; doesn't seem to like spacing in e.g. <[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)]T> |
|
@dougbu Yep, I'm trying to grok why it no longer respects the fact that we have EDIT: I know we recently did some rejigging with our EDIT 2: Making the following changes seems to resolve the issues so I'll just do that to unblock. - <[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)]T>
+ <[DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] T> |
TanayParikh
approved these changes
Jan 31, 2022
LGTM though looks like the CI found some more IDE0055.
|
The rule is enabled in CLI builds and the CLI update is discovering new places that weren't previously being flagged. Seems fine. |
pranavkm
approved these changes
Jan 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Weekly build-ops rotation update.
The text was updated successfully, but these errors were encountered: