The Wayback Machine - https://web.archive.org/web/20220202231153/https://github.com/dotnet/aspnetcore/pull/39945
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Also build npm projects in parallel #39945

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Also build npm projects in parallel #39945

wants to merge 1 commit into from
+14 −5

Conversation

@dougbu
Copy link
Member

@dougbu dougbu commented Feb 2, 2022

  • extend %(RestoreInParallel) choice to %(BuildInParallel)

nits:

  • use <ItemDefinitionGroup />
  • remove reference to non-existent .npmproj files
@dougbu
Also build npm projects in parallel
5f66584 
- extend `%(RestoreInParallel)` choice to `%(BuildInParallel)`

nits:
- use `<ItemDefinitionGroup />`
- remove reference to non-existent .npmproj files
@dougbu dougbu requested review from BrennanConroy and Feb 2, 2022
@dougbu
Copy link
Member Author

@dougbu dougbu commented Feb 2, 2022

This should reduce the "waiting for yarn" messages in local builds and (perceived) contention in CI builds.

@dougbu
Copy link
Member Author

@dougbu dougbu commented Feb 2, 2022

But, I got something wrong…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy

@dotnet/aspnet-build aspnet-build

@dotnet/aspnet-blazor-eng aspnet-blazor-eng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
1 participant
@dougbu