The Wayback Machine - https://web.archive.org/web/20220205195708/https://github.com/dotnet/aspnetcore/pull/40018
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better way to detect "Failed to start the HttpConnection before stop() was called." #40018

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Better way to detect "Failed to start the HttpConnection before stop() was called." #40018

wants to merge 2 commits into from
+40 −12

Conversation

@z77ma
Copy link
Contributor

@z77ma z77ma commented Feb 5, 2022 •
edited

Use specifically typed error when connection failed to start

The AbortError is used to mark a situation when a stop() method is being invoked before a call to start() succeeds.

Description

As proposed in the issue the specific error is returned in case stop was called before start ended in the HttpConnection and HubConnection classes

Fixes #38893
@z77ma
Copy link
Contributor Author

@z77ma z77ma commented Feb 5, 2022

Hi, @halter73, could you check if I understood your suggestion in the issue correct? Thanks.

@z77ma z77ma changed the title Enchacement/38893 Better way to detect "Failed to start the HttpConnection before stop() was called." Feb 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BrennanConroy BrennanConroy

@halter73 halter73

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-signalr community-contribution
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

Better way to detect "Failed to start the HttpConnection before stop() was called."
1 participant
@z77ma