The Wayback Machine - https://web.archive.org/web/20220210100955/https://github.com/dotnet/aspnetcore/pull/40085
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not install the JDK in quarantined pipelines #40085

Merged
merged 2 commits into from Feb 10, 2022
Merged

Do not install the JDK in quarantined pipelines #40085

merged 2 commits into from Feb 10, 2022
+20 −11

Conversation

@dougbu
Copy link
Member

@dougbu dougbu commented Feb 9, 2022

  • was mainly used to confirm support for Components E2E tests
  • those tests built more often than required

nit: do not set $(SkipTests) to false
@dougbu dougbu requested review from SteveSandersonMS and Feb 9, 2022
@dougbu dougbu marked this pull request as ready for review Feb 9, 2022
@dougbu dougbu requested a review from as a code owner Feb 9, 2022
@dougbu
Copy link
Member Author

@dougbu dougbu commented Feb 9, 2022 •
edited

Turns out this PR is mostly about not building Components.E2ETests except in the dedicated pipeline

wtgodbe
wtgodbe approved these changes Feb 9, 2022
View changes
@dougbu dougbu force-pushed the dougbu/install.java.less branch from 70ff6c7 to d1ca485 Feb 9, 2022
dougbu added 2 commits Feb 9, 2022
@dougbu
Do not install the JDK in quarantined pipelines
1a100fc 
- was mainly used to confirm support for Components E2E tests
- those tests built more often than required

nit: do not set `$(SkipTests)` to `false`
@dougbu
Address review comments
35435c1 
- quote "true" in `Condition`s
@dougbu dougbu force-pushed the dougbu/install.java.less branch from ad804c6 to 35435c1 Feb 9, 2022
@dougbu dougbu enabled auto-merge (squash) Feb 10, 2022
@dougbu dougbu merged commit 15958fe into dotnet:main Feb 10, 2022
25 checks passed
@dougbu dougbu deleted the dougbu/install.java.less branch Feb 10, 2022
@msftbot msftbot bot added this to the 7.0-preview2 milestone Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rainersigwald rainersigwald

@wtgodbe wtgodbe

@SteveSandersonMS SteveSandersonMS

@dotnet/aspnet-blazor-eng aspnet-blazor-eng

@Tratcher Tratcher

@halter73 halter73

@BrennanConroy BrennanConroy

@pranavkm pranavkm

@javiercn javiercn

@Pilchie Pilchie

Assignees
No one assigned
Labels
area-infrastructure
Projects
None yet
Milestone
7.0-preview2
Linked issues

Successfully merging this pull request may close these issues.

None yet
4 participants
@dougbu @rainersigwald @wtgodbe @Pilchie