The Wayback Machine - https://web.archive.org/web/20220209190033/https://github.com/dotnet/aspnetcore/pull/40101
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port https://github.com/dotnet/aspnetcore/pull/38814 to 6.0 #40101

Open
wants to merge 1 commit into
base: release/6.0
Choose a base branch
from

Conversation

@pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Feb 9, 2022

No description provided.

@msftbot msftbot bot added this to the 6.0.x milestone Feb 9, 2022
@msftbot msftbot bot added this to In Progress in Servicing Feb 9, 2022
@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Feb 9, 2022

Hi @pranavkm. If this is not a tell-mode PR, please make sure to follow the instructions laid out in the servicing process document.
Otherwise, please add tell-mode label.

@Pilchie
Copy link
Member

@Pilchie Pilchie commented Feb 9, 2022

The goal is to increase coverage in servicing? Sounds good to me.

@pranavkm pranavkm requested a review from dougbu Feb 9, 2022
@pranavkm
Copy link
Contributor Author

@pranavkm pranavkm commented Feb 9, 2022

@dougbu had attempted to port this back to 6.0 yesterday: #38814 (comment). I'm not super sure of the background on this though.

Copy link
Member

@dougbu dougbu left a comment

We need the following in this PR or the branch is going to get more flaky
https://github.com/dotnet/aspnetcore/blob/main/eng/test-configuration.json#L11

That was visible in #38814 but not 9c29067 for some reason


<!-- https://github.com/dotnet/aspnetcore/issues/38819 LocalDb sometimes hangs on win11 helix queue -->
<BuildHelixPayload>false</BuildHelixPayload>
Copy link
Member

@dougbu dougbu Feb 9, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dougbu had attempted to port this back to 6.0 yesterday: #38814 (comment). I'm not super sure of the background on this though.

The background is we need this addition in release/6.0 to get PRs passing because LocalDB isn't reliable where we need it to be reliable.

The un-quarantining is also fine as long as the tests have been just as reliable in this branch. If the test or test infrastructure isn't up to the task, we should backport only this change. I'm not familiar enough w/ the tests to know either way and am asking the gathered masses (as I would have if the backport bot could work)…

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Servicing
In Progress
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants