Formed in 2009, the Archive Team (not to be confused with the archive.org Archive-It Team) is a rogue archivist collective dedicated to saving copies of rapidly dying or deleted websites for the sake of history and digital heritage. The group is 100% composed of volunteers and interested parties, and has expanded into a large amount of related projects for saving online and digital history.
Add the displayName Property to Project Template Parameters
#40105
+65
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TanayParikh
reviewed
Feb 9, 2022
src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-CSharp/.template.config/ide.host.json
Outdated
Show resolved
Hide resolved
TanayParikh
changed the title
displayNamesdisplayName Property to Project Template Parameters
TanayParikh
reviewed
Feb 9, 2022
src/ProjectTemplates/Web.ProjectTemplates/content/WebApi-CSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
This reverts commit 05758e2.
phenning
requested changes
Feb 9, 2022
See comments inline, one additional thing - now would be a good time to also remove all the strings.json files and the locale specific folders in the .template.config folder. Only the localize folder and the files it contains should remain.
We can do this in NET 7 because this new localization support has been shipping since 17.0 and NET 7 and later will not be supported in versions prior to Dev17, just like NET 6 templates are not supported in earlier versions as well.
src/ProjectTemplates/Web.ItemTemplates/content/Protobuf/.template.config/template.json
Outdated
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/RazorPage/.template.config/template.json
Show resolved
Hide resolved
src/ProjectTemplates/Web.ItemTemplates/content/ViewImports/.template.config/template.json
Outdated
Show resolved
Hide resolved
...s/Web.ProjectTemplates/content/ComponentsWebAssembly-CSharp/.template.config/en/strings.json
Show resolved
Hide resolved
...ojectTemplates/Web.ProjectTemplates/content/StarterWeb-FSharp/.template.config/template.json
Outdated
Show resolved
Hide resolved
|
The WebAPI override also working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Add the
displayNameProperty to Project Template ParametersImproves display of project template parameters by providing an easily readable parameter name.
Currently:
After:
Description
Recent changes which enabled template localization (#38867) omitted the new
displayNameproperty, which led to VS using the parameter id/name instead. This is non-localized and comes in the form ofcamelCase,UpperCamelCaseorkebab-case.Fixes aspnet/AspNetCore-ManualTests#1154
Customer Impact
The property id/name is being used instead of a more legible property display name. This can manifest itself in
camelCase,UpperCamelCaseorkebab-casecase like below:Regression?
Visual Studio 17 Preview 1.
Risk
Verification
Packaging changes reviewed?
The text was updated successfully, but these errors were encountered: