The Wayback Machine - https://web.archive.org/web/20220210193137/https://github.com/dotnet/aspnetcore/pull/40128
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete ProjectTemplates strings.json #40128

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Delete ProjectTemplates strings.json #40128

wants to merge 1 commit into from
+0 −1,368

Conversation

@TanayParikh
Copy link
Member

@TanayParikh TanayParikh commented Feb 10, 2022

All the strings.json files can be removed, since in Dev17 they will never be loaded, since the template ships with templatestrings.en.json.

The localize/templatestrings.en.json files are now used instead.

Fixes: #40107
@TanayParikh TanayParikh requested review from phenning and Feb 10, 2022
@TanayParikh TanayParikh force-pushed the taparik/deleteStringsJson branch from f84f475 to 4ab4518 Feb 10, 2022
@TanayParikh TanayParikh removed request for , Pilchie, dougbu and wtgodbe Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phenning phenning

@dotnet/aspnet-blazor-eng aspnet-blazor-eng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

All the strings.json files can be removed
1 participant
@TanayParikh