The Wayback Machine - https://web.archive.org/web/20220211020616/https://github.com/dotnet/aspnetcore/pull/40133
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address some infrastructure nits #40133

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Address some infrastructure nits #40133

wants to merge 1 commit into from
+38 −34

Conversation

@dougbu
Copy link
Member

@dougbu dougbu commented Feb 11, 2022

  • allow RunHelix.ps1 to use any Helix queue
  • remove useless $(IsPackable) setting
  • remove an extra App.Runtime reference; App.Ref brings it in
  • in helix.proj:
    • tie into inner BeforeTest target; ignore Build target
      • do less work e.g. perform a few fewer up-to-date checks
    • don't load NuGet.targets
    • use <Choose/> to make some either/or options more obvious
    • remove some settings
      • e.g. leave $(HelixTestConfigurationFilePath) stuff to the Helix SDK
      • Helix SDK does most of these but $(EnableXUnitReporter) has been obsolete for a while
@dougbu
Address some infrastructure nits
8aec11f 
- allow RunHelix.ps1 to use any Helix queue
- remove useless `$(IsPackable)` setting
- remove an extra App.Runtime reference; App.Ref brings it in
- in helix.proj:
  - tie into inner `BeforeTest` target; ignore `Build` target
    - do less work e.g. perform a few fewer up-to-date checks
  - don't load NuGet.targets
  - use `<Choose/>` to make some either/or options more obvious
  - remove some settings
    - e.g. leave `$(HelixTestConfigurationFilePath)` stuff to the Helix SDK
    - Helix SDK does most of these but `$(EnableXUnitReporter)` has been obsolete for a while
@dougbu dougbu requested review from HaoK and Feb 11, 2022
@dougbu dougbu requested a review from Pilchie as a code owner Feb 11, 2022
HaoK
HaoK reviewed Feb 11, 2022
View changes
eng/helix/helix.proj
@@ -75,10 +83,6 @@
<HelixProperties Condition="'$(RunQuarantinedTests)' != 'true'" Include="runType" Value="unquarantined" />
</ItemGroup>

<ItemGroup Condition="Exists('$(HelixTestConfigurationFilePath)')">
<HelixCorrelationPayload Include="$(HelixTestConfigurationFilePath)" AsArchive="false" />
Copy link
Member

@HaoK HaoK Feb 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming the helix sdk is doing this for us now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaoK HaoK

@dotnet/aspnet-build aspnet-build

@Pilchie Pilchie

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
area-infrastructure
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@dougbu @HaoK