The Wayback Machine - https://web.archive.org/web/20220215015704/https://github.com/dotnet/aspnetcore/pull/40234
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input components two way binding #40234

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

@hakenr
Copy link

@hakenr hakenr commented Feb 15, 2022

Input components two way binding

  • You've read the Contributor Guide and Code of Conduct.
  • You've included unit or integration tests for your change, where applicable.
  • You've included inline docs for your change, where applicable.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.

InputText and other input components do not use SetUpdatesAttributeName() for two-way binding. This PR adds missing SetUpdatesAttributeName() calls and aligns the code to @bind used by .razor.

Description

Discussed with @SteveSandersonMS in #40097. Added the missing two-way binding in input components and created E2E test for the changed behavior (every single added test was failing before the fix).

Fixes #40097

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant