The Wayback Machine - https://web.archive.org/web/20220216184102/https://github.com/dotnet/aspnetcore/pull/40269
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Annotate Microsoft.Authentication.WebAssembly.Msal for nullability #40269

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Annotate Microsoft.Authentication.WebAssembly.Msal for nullability #40269

wants to merge 2 commits into from
+52 −53

Conversation

@pranavkm
Copy link
Contributor

@pranavkm pranavkm commented Feb 16, 2022

Contributes to #5680
@pranavkm pranavkm requested review from as code owners Feb 16, 2022
@msftbot msftbot bot added the area-blazor label Feb 16, 2022
TanayParikh
TanayParikh reviewed Feb 16, 2022
View changes
Copy link
Member

@TanayParikh TanayParikh left a comment

LGTM so far, CI found a few missing areas.

@pranavkm pranavkm requested a review from Pilchie as a code owner Feb 16, 2022
@pranavkm
Copy link
Contributor Author

@pranavkm pranavkm commented Feb 16, 2022

main is currently bored and is being fixed by #40268. I rebased on that branch, so it should cause this to build, but would show that extra commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TanayParikh TanayParikh

@dotnet/aspnet-api-review aspnet-api-review

@Pilchie Pilchie

Assignees
No one assigned
Labels
area-blazor
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet
2 participants
@pranavkm @TanayParikh