The Wayback Machine - https://web.archive.org/web/20220226050739/https://github.com/tailwindlabs/tailwindcss/pull/7626
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalidate context when main css changes #7626

Merged
merged 4 commits into from Feb 25, 2022

Conversation

@thecrypticace
Copy link
Collaborator

@thecrypticace thecrypticace commented Feb 24, 2022

Because we can't rely on preprocessors tracking imports as dependencies through PostCSS the only way we can reliably reuse the context is by using a hash of the CSS tree. This will let us invalidate the context when using tools like Sass with imports that contain @layer directives.

Fixes #4838

@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch 3 times, most recently from 83d7e9e to 3cfb703 Feb 25, 2022
@thecrypticace thecrypticace marked this pull request as ready for review Feb 25, 2022
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from db4968d to 9121d40 Feb 25, 2022
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from 9121d40 to dc7b00a Feb 25, 2022
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from 0504e94 to e960034 Feb 25, 2022
@thecrypticace thecrypticace force-pushed the fix/context-invalidation-on-content-change branch from e960034 to 7aea65f Feb 25, 2022
@thecrypticace thecrypticace merged commit bd16763 into master Feb 25, 2022
11 checks passed
@thecrypticace thecrypticace deleted the fix/context-invalidation-on-content-change branch Feb 25, 2022
@florianbouvot
Copy link

@florianbouvot florianbouvot commented Feb 25, 2022

@thecrypticace you will make a lot of Tailwind CSS users happy 🥳

I've try to remove Sass from my workflow and it's pretty good too.

Thanks a lot

@davidwebca
Copy link

@davidwebca davidwebca commented Feb 25, 2022

Thank you for your hard work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

3 participants