New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API Deprecate max_feature=auto
for tree classes
#22476
API Deprecate max_feature=auto
for tree classes
#22476
Conversation
You will need to add some tests to check the behaviour of the warning and catch the warnings in all tests that are expected to raise the warning. |
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]>
Thanks for the update. The CI error comes from us during UserWarnings
into errors. We likely need to add a filter warning on some test fails to filter out warning. Something like this:
pytestmark = pytest.mark.filterwarnings( |
Hi @thomasjpfan , it seems like the failed test cases are scattered in a lot of different files due to the wide usage of tree models. I'm wondering if there's a way to ignore that specific warning by using a global configuration during the CI process or we need to add |
There looks to be only 4 files with warnings. For the following files, I suggest to update
For |
I just figured that I forgot to change the default value in the |
Please add an entry to the change log at doc/whats_new/v1.1.rst
with tag |API|. Like the other entries there, please reference this pull request with :pr:
and credit yourself (and other contributors if applicable) with :user:
.
Thanks @MaxwellLZH. Just a few nitpicks to help the cleaning in 1.3 and I think the deprecation warning test can be simplified.
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Jérémie du Boisberranger <[email protected]>
Co-authored-by: Thomas J. Fan <[email protected]> Co-authored-by: Jérémie du Boisberranger <[email protected]>
Reference Issues/PRs
This is a fix to issue #22458 .
What does this implement/fix? Explain your changes.
This PR made the following changes:
max_feature='auto'
ExtraTreeClassifier.max_feature
default value tosqrt
andExtraTreeRegressor.max_feature
default value to 1.0_forest._parallel_build_trees
function so we don't see repeated warning messages