DOC Fix axes3d matplotlib deprecation warning #22622
Merged
+4
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thomasjpfan
reviewed
Feb 26, 2022
Thanks for the PR!
There is a linting issue. We need to remove:
from mpl_toolkits.mplot3d import Axes3DBecause it is not used anymore.
|
@thomasjpfan just removed the import statement as asked. Please let me know if there are any other changes. Thanks for being patient with my first PR. |
thomasjpfan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Reference Issues/PRs
Part of #22586
What does this implement/fix? Explain your changes.
Removes the warning message produced by matplotlib in examples/decomposition/plot_pca_iris.py.
The warning states: "Pass the keyword argument auto_add_to_figure=False and use fig.add_axes(ax) to suppress this warning. The default value of auto_add_to_figure will change to False in mpl3.5 and True values will no longer work in 3.6."
Replaced a line like this:
ax = Axes3D(fig, elev=elev, azim=azim, rect=[0, 0, 0.95, 1])by:
as this was the recommended change to make in the reference issue.
Any other comments?
This is my first PR, so I'm sorry if there was any mistake in my submission. Please let me know if there are any changes, and I'll try my best to update accordingly.
The text was updated successfully, but these errors were encountered: