The Wayback Machine - https://web.archive.org/web/20220217185714/https://github.com/go-gitea/gitea/pull/18050
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Alpine from 3.13 to 3.15 #18050

Merged
merged 6 commits into from Jan 19, 2022
Merged

Conversation

@galibozek
Copy link
Contributor

@galibozek galibozek commented Dec 20, 2021

Upgrade Alpine from 3.13 to 3.15

⚠️ BREAKING ⚠️

Users with docker version < 20.10.6 have to upgrade their docker.

See: https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0 & https://about.gitlab.com/blog/2021/08/26/its-time-to-upgrade-docker-engine/

@zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 20, 2021

Have alpine sorted the reason why we had to downgrade back to 3.13 last year?

If not have sufficient numbers of people upgraded their dockers to prevent it from being problem?

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 20, 2021

This should help with the issue described in #17994 related to old npm.

@techknowlogick techknowlogick added this to the 1.17.0 milestone Dec 21, 2021
@zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 21, 2021

Let me be clearer:

Alpine 3.14+ will cause everyone using gitea with docker less than version 20.10.6 to break. (https://wiki.alpinelinux.org/wiki/Release_Notes_for_Alpine_3.14.0)

We upgraded to alpine 3.14 and had multiple bug reports like:

#16428, #16451, #16170, #16464, #16484

See:

https://about.gitlab.com/blog/2021/08/26/its-time-to-upgrade-docker-engine/

For when gitlab were finally bitten by this.

@zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 21, 2021

So the question is has enough of the docker community moved over to update their docker installs and have they been bitten elsewhere yet?

One option is to do this but also add a check in to Gitea that will check if this bug is present and report that we cannot run.

@wxiaoguang
Copy link
Contributor

@wxiaoguang wxiaoguang commented Dec 21, 2021

That's a lot of new information for me, too.

If we can write the background in comment, maybe new developers won't have questions anymore.

@zeripath
Copy link
Contributor

@zeripath zeripath commented Dec 21, 2021

So looking at:

alpinelinux/docker-alpine#156 (comment) & alpinelinux/docker-alpine#156 (comment)

May provide techniques for us to test at time of docker run if things are going to be broken.

if [ ! -x /bin/bash ]; then echo "I should not get printed!"; fi
Directory test also failed ( test -x /tmp then echo $? , got 1 )

@silverwind
Copy link
Member

@silverwind silverwind commented Dec 21, 2021

Docker is just a dependency in this case. We should document its minimum version and possible refuse to run if it's too old. Question is, can a container detect the version of the docker daemon it runs on?

@eeyrjmr
Copy link
Contributor

@eeyrjmr eeyrjmr commented Dec 27, 2021

Docker is just a dependency in this case. We should document its minimum version and possible refuse to run if it's too old. Question is, can a container detect the version of the docker daemon it runs on?

this might do it
cat /proc/self/cgroup | grep -o -e "docker-.*.scope" | head -n 1 | sed "s/docker-\(.*\).scope/\\1/"

@techknowlogick techknowlogick merged commit 4563148 into go-gitea:main Jan 19, 2022
1 check was pending
zjjhot pushed a commit to zjjhot/gitea that referenced this issue Jan 20, 2022
* 'main' of https://github.com/go-gitea/gitea:
  Change initial TrustModel to committer (go-gitea#18335)
  refactor httplib (go-gitea#18338)
  Propagate context and ensure git commands run in request context (go-gitea#17868)
  Upgrade Alpine from 3.13 to 3.15 (go-gitea#18050)
  [skip ci] Updated translations via Crowdin
  Stop trimming preceding and suffixing spaces from editor filenames (go-gitea#18334)
  [skip ci] Updated translations via Crowdin
  Left-Align text in Unicode warning boxes (go-gitea#18331)
  Only warn on bidi but still escape non-bidi (go-gitea#18333)
  Fix incorrect OAuth message (go-gitea#18332)
  [skip ci] Updated translations via Crowdin
  Changelog for 1.16.0-rc1 (go-gitea#18309)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked issues

Successfully merging this pull request may close these issues.

None yet

7 participants