The Wayback Machine - https://web.archive.org/web/20211006153950/https://github.com/segmentio/kafka-go/pull/596

segmentio / kafka-go Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kafka Client FindCoordinator implementation #596

Merged

achille-roussel merged 10 commits into segmentio:master from live-wire:findCoordinator

Feb 19, 2021

Contributor

live-wire commented Jan 24, 2021

This pull request contains

FIndCoordinator implementation that utilizes the kafka.(*Client) abstraction.
A tiny unit test for the same.

According to this design doc, the first step in implementing a Transactional Producer is looking for a TransactionCoordinator for the specified transactionalId using FindCoordinatorRequest.

This PR is a step towards solving #233

CC: @achille-roussel

The text was updated successfully, but these errors were encountered:

live-wire added 4 commits


          Kafka client Find coordinator implementation

70aa5ef


          Added retries to Find coordinator test

98c903b


          Updated findcoordinator with indefinite wait function

fd4fa35


          Refactored findcoordinator retry check into a function

c4ad201

live-wire mentioned this pull request

InitProducerId implementation for a Transactional Producer #597

Merged


          Increased coordinator wait period

6f3f7db

achille-roussel reviewed

Contributor

achille-roussel left a comment

Thanks for your contribution @live-wire !

I left a few comments, let me know what you think about it.

findcoordinator.go Outdated Show resolved Hide resolved

findcoordinator.go Outdated Show resolved Hide resolved

findcoordinator.go Outdated Show resolved Hide resolved

achille-roussel self-assigned this

live-wire added 2 commits


          FindCoordinator updates for keeping the public API consistent

0486a56


          Moved waiting for coordinator implementation to the test file

358e45f

Contributor Author

live-wire commented Feb 15, 2021

Hello @achille-roussel ,

I made the following updates:

Removed WaitForCoordinator function from the kafka.(*Client) API.
Moved the waitingForCoordinator indefinitely to the test file. (The test needs wait for coordinator initialisation).
Created a new struct to hold error and error code information.
Made the other suggested fixes.

Please have a look.

achille-roussel reviewed

error.go Outdated Show resolved Hide resolved


          makeError error already contains kafka.Error information

80ca38a

Contributor Author

live-wire commented Feb 16, 2021

@achille-roussel I made the suggested changes.


          Extra comment in test to re-trigger Snyk

7a359c4

live-wire force-pushed the findCoordinator branch from 50a55ef to 7a359c4

achille-roussel reviewed

findcoordinator.go Outdated Show resolved Hide resolved


          Response error should be nil even if kafka responds with an error code

0cffb73

achille-roussel approved these changes

Contributor

achille-roussel left a comment

Thanks for the contribution 👍

achille-roussel approved these changes

achille-roussel merged commit fbe3d96 into segmentio:master

11 checks passed

dependabot bot mentioned this pull request

⬆️ Bump github.com/segmentio/kafka-go from 0.4.9 to 0.4.11 ccamel/go-graphql-subscription-example#259

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment