The Wayback Machine - https://web.archive.org/web/20211006154245/https://github.com/segmentio/kafka-go/pull/735
Skip to content

/ kafka-go Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Offsetcommit to Client #735

Merged
merged 5 commits into from Sep 13, 2021
Merged

Add Offsetcommit to Client #735

merged 5 commits into from Sep 13, 2021

Conversation

@rhansen2
Copy link
Collaborator

@rhansen2 rhansen2 commented Sep 13, 2021

No description provided.

achille-roussel and others added 5 commits Sep 13, 2021
@achille-roussel @rhansen2
add OffsetCommit API
a178ed3
@achille-roussel @rhansen2
support more recent API versions
44dd38b
@achille-roussel @rhansen2
GroupInstanceID must be nullable
34c6adb
@rhansen2
Add test for offsetcommit
2938627
@rhansen2
Add tests for Request/Response type.
2c0c2fd
achille-roussel
achille-roussel approved these changes Sep 13, 2021
View changes
Copy link
Contributor

@achille-roussel achille-roussel left a comment

Thanks for picking this up and adding tests 🙇

@rhansen2 rhansen2 merged commit 433e383 into segmentio:master Sep 13, 2021
12 checks passed
@rhansen2 rhansen2 deleted the offsetcommit branch Sep 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@achille-roussel achille-roussel

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@rhansen2 @achille-roussel