lint files #4416
Merged
lint files #4416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
phapdinh
reviewed
Aug 17, 2019
.eslintrc.js
Outdated
| @@ -83,7 +83,7 @@ module.exports = { | |||
| 'requireReturnForObjectLiteral': false | |||
| }], | |||
|
|
|||
| 'arrow-parens': ['error', 'always'], | |||
| // 'arrow-parens': ['error', 'always'], | |||
There was a problem hiding this comment.
I commented out this rule because sometimes arrow functions if they have only one parameter don't need parens
There was a problem hiding this comment.
It's fine to enable. I want to be consistent and always use parens.
There was a problem hiding this comment.
@jdalton I have added back this rule and now npm run style passes
Closed
|
Thank you @phapdinh! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
This fixes issue issue #4415