The Wayback Machine - https://web.archive.org/web/20220724042128/https://github.com/go-gitea/gitea/pull/17061
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix commit status index problem #17061

Merged
merged 9 commits into from Sep 23, 2021
Merged

Fix commit status index problem #17061

merged 9 commits into from Sep 23, 2021

Conversation

lunny
Copy link
Member

@lunny lunny commented Sep 15, 2021

Replace #14160 and fix #14059

zeripath
zeripath reviewed Sep 15, 2021
View changes
models/commit_status.go Outdated Show resolved Hide resolved
@zeripath
Copy link
Contributor

@zeripath zeripath commented Sep 15, 2021

Is the ID column is necessary? Could we use a composite pk?

@lunny
Copy link
Member Author

@lunny lunny commented Sep 16, 2021

Is the ID column is necessary? Could we use a composite pk?

Composite primary key makes things more complicated, I would like to add a ID column.

@lunny lunny force-pushed the lunny/fix_commit_status_index branch from a007290 to 3091c8e Compare Sep 16, 2021
@lunny lunny added the kind/bug label Sep 16, 2021
@lunny lunny added this to the 1.16.0 milestone Sep 16, 2021
@lunny lunny force-pushed the lunny/fix_commit_status_index branch 3 times, most recently from 16db18d to 49f9c40 Compare Sep 22, 2021
zeripath
zeripath reviewed Sep 22, 2021
View changes
Copy link
Contributor

@zeripath zeripath left a comment

ugh this is still failing tests.

@lunny lunny force-pushed the lunny/fix_commit_status_index branch from bd59b59 to ebaa9a6 Compare Sep 23, 2021
@lunny
Copy link
Member Author

@lunny lunny commented Sep 23, 2021

@zeripath PASS now.

@lunny lunny merged commit d9c6959 into go-gitea:main Sep 23, 2021
2 checks passed
@lunny lunny deleted the lunny/fix_commit_status_index branch Sep 23, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath

@delvh delvh

@axifive axifive

Assignees
No one assigned
Labels
kind/bug lgtm/done
Milestone
1.16.0
Development

Successfully merging this pull request may close these issues.

Commit build status not updating (intermittent)
5 participants
@lunny @zeripath @axifive @delvh @GiteaBot