The Wayback Machine - https://web.archive.org/web/20220220084830/https://github.com/go-gitea/gitea/pull/16719
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add edit button to wiki sidebar and footer #16719

Merged
merged 4 commits into from Aug 18, 2021

Conversation

@n194
Copy link
Contributor

@n194 n194 commented Aug 18, 2021

This PR adds an edit button to wiki sidebars and footer

Closes #16655

@silverwind
Copy link
Member

@silverwind silverwind commented Aug 18, 2021

I think it should either be with a transparent background or with border and background (e.g. replace label with button class).

@n194
Copy link
Contributor Author

@n194 n194 commented Aug 18, 2021

@silverwind I tried it with the button class but there were some alignment/overflow issues. I can make it transparent, is there a class that I can use to revert the blue color of a link?

@silverwind
Copy link
Member

@silverwind silverwind commented Aug 18, 2021

Yes, add muted class to the <a>.

@n194
Copy link
Contributor Author

@n194 n194 commented Aug 18, 2021

Fixed
screenshot

@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Aug 18, 2021

Codecov Report

Merging #16719 (213a856) into main (9f0c8f9) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16719      +/-   ##
==========================================
- Coverage   45.36%   45.35%   -0.01%     
==========================================
  Files         760      760              
  Lines       85482    85482              
==========================================
- Hits        38775    38774       -1     
- Misses      40424    40426       +2     
+ Partials     6283     6282       -1     
Impacted Files Coverage Δ
services/pull/temp_repo.go 30.76% <0.00%> (-3.85%) ⬇️
services/pull/check.go 25.51% <0.00%> (-2.76%) ⬇️
services/pull/patch.go 54.23% <0.00%> (-1.70%) ⬇️
routers/web/repo/view.go 40.95% <0.00%> (-0.58%) ⬇️
services/pull/pull.go 41.78% <0.00%> (ø)
services/gitdiff/gitdiff.go 74.23% <0.00%> (+0.97%) ⬆️
modules/log/event.go 62.50% <0.00%> (+1.85%) ⬆️
modules/charset/charset.go 73.73% <0.00%> (+2.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f0c8f9...213a856. Read the comment docs.

@lafriks lafriks added this to the 1.16.0 milestone Aug 18, 2021
@silverwind
Copy link
Member

@silverwind silverwind commented Aug 18, 2021

BTW we really need to add some UI later to create sidebar and footer.

Edit, see: #16655

@techknowlogick techknowlogick merged commit 4aa3cac into go-gitea:main Aug 18, 2021
2 checks passed
@n194 n194 deleted the wiki-edit-button branch Aug 19, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Linked issues

Successfully merging this pull request may close these issues.

8 participants