The Wayback Machine - https://web.archive.org/web/20220315194942/https://github.com/go-gitea/gitea/pull/16897
Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip and limit to git.GetTags #16897

Merged
merged 5 commits into from Sep 10, 2021
Merged

Add skip and limit to git.GetTags #16897

merged 5 commits into from Sep 10, 2021

Conversation

6543
Copy link
Member

@6543 6543 commented Aug 31, 2021 •
edited

  • Make GetTags() api similar to GetBranches()
  • Use it for Tag/Release page

@6543 6543 force-pushed the git.GetTags-paginate branch from 95d17de to ee1d856 Sep 9, 2021
@codecov-commenter
Copy link

@codecov-commenter codecov-commenter commented Sep 9, 2021 •
edited

Codecov Report

Merging #16897 (a5bbe02) into main (4c7a70b) will increase coverage by 0.03%.
The diff coverage is 49.49%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #16897      +/-   ##
==========================================
+ Coverage   45.17%   45.21%   +0.03%     
==========================================
  Files         762      766       +4     
  Lines       86174    86596     +422     
==========================================
+ Hits        38932    39155     +223     
- Misses      40948    41102     +154     
- Partials     6294     6339      +45
Impacted Files Coverage Δ
cmd/admin.go 0.00% <0.00%> (ø)
cmd/doctor.go 0.00% <ø> (ø)
models/attachment.go 57.89% <0.00%> (-0.68%) ⬇️
modules/migrations/gitea_downloader.go 0.88% <0.00%> (-0.01%) ⬇️
modules/migrations/migrate.go 27.79% <ø> (ø)
modules/setting/repository.go 58.49% <ø> (ø)
modules/storage/minio.go 58.18% <0.00%> (ø)
modules/templates/helper.go 51.36% <0.00%> (ø)
routers/api/v1/repo/migrate.go 44.17% <0.00%> (ø)
routers/api/v1/repo/mirror.go 0.00% <0.00%> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ca0e79...a5bbe02. Read the comment docs.

@6543 6543 marked this pull request as ready for review Sep 9, 2021
@6543 6543 added this to the 1.16.0 milestone Sep 9, 2021
lunny
lunny approved these changes Sep 10, 2021
View changes
@6543 6543 merged commit 77f604a into go-gitea:main Sep 10, 2021
2 checks passed
@6543 6543 deleted the git.GetTags-paginate branch Sep 10, 2021
@go-gitea go-gitea locked and limited conversation to collaborators Oct 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lunny lunny

@zeripath zeripath

Assignees
No one assigned
Labels
kind/refactor lgtm/done
Milestone
1.16.0
Linked issues

Successfully merging this pull request may close these issues.

None yet
5 participants
@6543 @codecov-commenter @lunny @zeripath @GiteaBot